-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/30884: Redirect to upload screen if file is lost #33562
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/AAndroid: mWeb ChromeScreen.Recording.2024-01-09.at.15.46.51.moviOS: NativeN/AiOS: mWeb SafariScreen.Recording.2024-01-09.at.15.47.58.movMacOS: Chrome / SafariScreen.Recording.2024-01-09.at.15.22.32.movMacOS: DesktopScreen.Recording.2024-01-09.at.15.49.57.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Bug:
- Open a chat
- Create a manual request thought the chat plus icon
- Enter an amount and click Next
- Refresh the page
- Click back icon on the top left
- Notice you're not redirected to the previous step, the same step is shown
Screen.Recording.2024-01-03.at.16.54.35.mov
- Bug:
- Open a chat
- Create a manual request thought the chat plus icon
- Enter an amount and Next
- Click the three dots on the top, and attach a receipt
- Refresh the page
- Click back icon on the top left 3 times (to get to the first step)
- Click next
- Notice you're navigated directly to "Upload receipt" page instead of the next step (essentially app doesn't allow you to proceed without uploading a receipt)
Screen.Recording.2024-01-03.at.16.59.20.mov
@eVoloshchak I can't reproduce the first bug after merging the latest main Screen.Recording.2024-01-04.at.21.16.41.movAbout the second bug, after reloading page the file is lost but the file name and the source still exist in a transaction. So that, when going to the confirmation page |
@eVoloshchak I updated the code to reset the source and fileName after reloading. sol.mp4 |
@@ -3,6 +3,7 @@ import type {ValueOf} from 'type-fest'; | |||
import CONST from '@src/CONST'; | |||
import ROUTES from '@src/ROUTES'; | |||
import type {Report, Transaction} from '@src/types/onyx'; | |||
import * as IOU from './actions/IOU'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import * as IOU from './actions/IOU'; | |
import * as IOU from '@userActions/IOU'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.24-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀
|
Hello @eVoloshchak @DylanDylann This PR created a dependency cycle. Can you fix this in a PR? |
Details
Page refresh causes manual requests with a receipt to be stuck because after reloading page the file is lost
Fixed Issues
$ #30884
PROPOSAL: #30884 (comment)
Tests
Offline tests
Same above
QA Steps
Same above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Only can reproduce on browserAndroid: mWeb Chrome
c1.mp4
iOS: Native
Only can reproduce on browseriOS: mWeb Safari
s1.mp4
MacOS: Chrome / Safari
w1.mp4
MacOS: Desktop
Only can reproduce on browser